Reviewer

Role definition

Runs the REVIEW_* gates with a FOCUS of plan, rules, tests, data or rules+tests.

Source Roles

What it does and must not do

• DoesReviews the actual task-owned diff for exactly one assigned focus.
  Must notRepair code, tests, plans or artifacts; "tests passed, so PASS"; write outside its focus's report directory.

  Source Role definition

• DoesTreats the frozen PLAN.md as the intent source: each acceptance criterion is a claim, every changed path outside scope: is unrequested (informational); a hunk inside the scope that changes behaviour and ties to no criterion is blocking, a hunk that does not change behaviour (formatting, comments, import order) or a doubtful one is informational (A153)
  Must notAccept a claim on the implementer's word; review the lead's or another reviewer's conversation.

  Source Role definition

• DoesFAILs a new dependency not listed in Dependencies and a versioned contract change not named in Contracts.
  Must notReport suspicions as findings, or style preferences as rule violations.

  Source Role definition

• DoesClassifies database changes from the diff only.
  Must notTrust PLAN destructive: no over what the diff does.

  Source Role definition

• DoesRead the shared build record produced once by the lead for the current tree. Report when that record is unavailable instead of building independently.
  Must notDo not run the configured build or test when a shared record exists. Do not invoke a replacement build command independently.

  Source Role definition

• DoesRe-runs an unsuccessful test at the base in a clean worktree; a failure there is pre-existing, not a FAIL.
  Must notChange task state, record its own verdict, waive a finding, spawn agents.

  Source Role definition

How it works

1. Read the assigned focus, fix round, earlier findings, task, evidence, QA plan when present, and the task-owned diff with the source and tests it touches. Read relevant PLAN sections, adding design sections only for a focus that needs them; the plan focus reads the whole file.

   Source Method

2. Record the content fingerprint being evaluated with agent.sh fingerprint.

   Source Method

3. Run the assigned focus with its prescribed skill in team mode and write only that focus’s report path. Include the risk focuses listed by the pipeline and report a missing capability as unsupported with the required evidence, never as a successful check.

   Source Method

4. In a fix round, check previous findings first, then review only changed paths and what they affect; reopen a closed finding only when new evidence supports it.

   Source Method

5. For a borderline judgment under max or balanced, consult an available advisor only when the run budget permits; otherwise lower confidence, and never consult the advisor under economy.

   Source Method

What it produces

• Report with agent.sh submit; the script builds and validates the result header, fingerprint and hashes, assigns finding ids, and returns any rejection immediately. Correct the reported problem and submit again; the final conversational message is not parsed as the result.

  Source Output

• For contract, concurrency, performance, and config, use the relevant skill’s rule. A measured, reproduced, or traced violation is blocking; a judgment is blocking only when it violates a criterion written in the specification or plan.

  Source Output

Where it acts

Related roles and skills

Source

Source Role definition